Katello/katello — pull request #176 by pitr-ch (2012-06-04 09:03:40+00:00)
Title: katello - remove 'rescue Exception'

DO NOT MERGE

I am working on removing 'rescue Exception => e' from katello code. It can cause errors to be swallowed unintentionally, see [1] for more.

All 'rescue Exception => e' were removed and replaced with standard 'rescue => e'.

The code now contains a lot of 'rescue => e' even on places where exceptions could be specified more precisely. Complete list is in [2], [3]. If you see your name there, I would ask you for help to specify the exception classes and push changes back into branch exception_handling in Katello/katello [4]. Please mark lines in [2] and [3] as reviewed.

I will retest the branch in a week.

Thanks

[1] http://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby
[2] https://github.com/Katello/katello/blob/exception_handling/src/rescue_exception.txt
[3] https://github.com/Katello/katello/blob/exception_handling/src/rescue_runtime_error.txt
[4] https://github.com/Katello/katello/tree/exception_handling