spree/spree_paypal_express — pull request #66 by sbounmy (2012-06-02 07:08:39+00:00)
Title: Major changes and clean up

My branch name is called 'custom' because my first intention was to make spree_store_credits compatible with spree_paypal_express, but I end up fixing a lot of features and though it would be great if this get merged into spree's repo:

- fixed capture and credit from /admin broken by spree 1.1 payment processing changes (fixes #54)
- paypal_confirm page displays the same page as order_confirm
- order.completed_at is now set on paypal_finish
- on checkout with paypal, order is automatically updated so promotions, coupons are computed before we land on paypal's page (fixes #63)
- cleaned up dependencies
- we consume user's store_credits if spree_store_credits is defined

The spec coverage is not as good as it should be, but I tried to add some spec and setup integrations test if anyone wants to help with.
This PR is actually tested with preferred_review set to true and deployed on production, but would love any feedback.