fluidinfo/obrowser-chrome-extension — pull request #106 by terrycojones (2012-06-01 11:19:48+00:00)
Title: widen-sidebar-on-twitter-login-105

This ticket is misnamed, as it started out as an attempt to allow OAuth login in the sidebar. That turns out to be impossible (see comment in ticket as for why).

This branch instead implements OAuth login in a separate tab. When you click log in, the tab opens, you click authorize, the tab is closed, and you're returned to the page you were looking at. The sidebar updates in the tab you were looking at so that you see the logged-in view (it currently hides itself and then slides out again. I've not looked at why, will in another ticket). I tried to make this work in a separate pop-up window, but that was giving me trouble (I don't remember the details) and would, I think, be subject to pop-up blocking.

If you deny the authorization, the tab that was opened lives on, allowing the user to go wherever they want in it (Twitter offers several options as to where the user might want to go next).

I also did a little clean-up so that the extension just has one variable holding the hostname of the fluidinfo.com site that's in use, and so we can run against a different fluiddb instance too if required.

Let me know if you need help in testing.