rails/rails — pull request #6526 by amutz (2012-05-29 03:21:55+00:00)
Title: Decoupling ActiveSupport from ActionView

Hi,

I'm interested in using the ActiveSupport::Testing::Performance module and was surprised to see that it requires and calls code from ActionView. I'd like to use this module in a context without ActionView, and now that we've moved NumberHelpers to ActiveSupport (https://github.com/rails/rails/pull/6315), we can do this.

In this pull request I'm changing ActiveSupport::Testing::Performance to use ActiveSupport::NumberHelper instead of ActionView::Helpers::NumberHelper. Also, to my knowledge this logic was untested, so I have added tests for the formatting logic (which pass before and after the code change).

Any and all feedback is welcome.

Thanks!
-Andrew.