yfinkelstein/node-zookeeper — pull request #57 by mcavage (2012-05-28 16:41:38+00:00)
Title: Support SmartOS platform, move to GYP

This PR is in reference to #45

Sorry this took so long, but ultimately I figured this would be more burden on you than it should be, and in particular, other language bindings on Solaris should be able to leverage zookeeper. To that end (since I work at Joyent), we've put the forked/patched zookeeper into the OS-maintained package repository (pkgsrc), so it is now easily available to all clients.

To have your package support this sanely, I rejiggered your build process to do what you were doing before on Mac/Linux (curl+configure+make), but check for ZK in pkgsrc if it's on a SmartOS install. Lastly, I moved the project to GYP, since for all intents and purposes 0.4 is dead, and WAF is supposedly going away in a soon-ish release. I've tested this on Mac/Linux/SmartOS with node 0.6 and 0.7, and it seems to install/work in all cases.

I should have done this in a separate branch, and just done a squash so the commit history was a little nicer, but I didn't. I hope that's ok.

Thanks!
~Mark