nltk/nltk — pull request #260 by kacperChwialkowski (2012-05-26 22:20:41+00:00)
Title: Issue #147 (MaltEval in nltk.parse.malt?) addressed

Hi,

I have created basic MaltEval interface implementation. I would appreciate very much if you could review my code and give me some feedback.There are also some issues that need to be discussed

1) While .docstest are really nice feature, they do not allow me to test all my code. Consider situation in which we want test suite to run in environment where MaltEval.jar might be missing. In unit test we can write

@unittest.skipIf(Malteval.can_configure_properly()==False,"MaltEval.jar could not be found automatically ")
def test_run_default_cmd(self):
.....
where static method Malteval.can_configure_properly() checks if we can find MaltEval.jar automatically. If we can't, test will be skipped and reason will be logged. This can not be achieved in .doctest so we will get error when in fact nothing bad has happened.

2) I have prepared class with unit tests for this interface, but i am not sure if you use unit tests. Should I put it to tests directory or somewhere else?

Finally I would like to emphasize that code that i have written is basic and easy. I will push further changes if we all will agree that this basic code fits well nltk structure. I am looking forward to hearing from you.

Kind regards,

Kacper Chwialkowski