warner/browserid — pull request #1 by shane-tomlinson (2012-05-23 10:49:02+00:00)
Title: Move the requiredEmail checks from resources/state.js to controllers/dialog.js. 

@warner - I moved the unit tests for requiredEmail into dialog.js' tests. I also added a ton of new tests that were not written when the tosURL/privacyURL code was added. I found a problem with the URL check code, it would allow any URL that started with http, meaning httpg would have been considered valid, so I changed this.

* Add the startExternalDependencies option when initializing the dialog controller, if set to false, no external dependencies are loaded. Used for testing.
* Add a new test to check for script containing emails.
* Add unit tests for tosURL and privacyURL.
* Add a testHelpers.testErrorNotVisible
* Removed the actions.js->doError and its tests, it is no longer used.