seancribbs/ripple — pull request #292 by nyarly (2012-05-24 01:08:18+00:00)
Title: Activesupport instrumentation

As it stands, this is sort of a bogus PR - I'm looking for feedback mostly on how to proceed.

I'm not entirely pleased with this implementation because a) alias_method_chain and b) it reaches deep into riak-client to get what it wants.

The alternative would be to modify riak-client to accept a "instrumentor" option and use that if it's available (essentially fold lib/ripple/instrumentation/http.rb and lib/ripple/instrumentation/protobuffs.rb into riak-client) and have Ripple send ActiveSupport::Notifications in (a la Excon).

And I'm not expecting this to be merged in this from because I've written no specs at all for it yet. Full stop.