AngelDE98/Catacomb-Snatch — pull request #1 by KyleBrodie (2012-05-22 04:34:46+00:00)
Title: Joypad Clean up

Here is my initial clean up of your code. If I have time I'll clean it up some more, but I think you should do it yourself so I will list the problems I noticed while reading your code.
* Almost everything in your classes are public when they really don't need to be nor should they be
* Axes should emulate the 4 shooting keys thereby eliminating the overhead in implementing mouse emulation (your changes to the MouseButtons and MojamComponent classes) making it independent of changes to those classes.
* Your in-game menus for binding ( (A)JoypadBindingsMenu.java ) is too entangled with JoypadHandler. It should access JoypadHandler through methods not direct memory manipulation. Then the JoypadHandler class can grow and change but still be able to fulfill those requests.

And I think thats it. Enjoy