openhatch/oh-bugimporters — pull request #3 by paulproteus (2012-05-21 23:35:36+00:00)
Title: Use scrapy.items.Item to clarify data export; preserve project name; ditch bite_size_bug_name

These commits clarify the data export interface -- see bugimporters/items.py for a spec of what data gets passed out through the data transport.

It also adds code that calculates a project name within the bug importer, rather than doing it within the data transit as before. This code mostly passes the tests when tested with oh-mainline, although to make it really pass you need a branch I'll be pushing momentarily. (Look for it on github.com/openhatch/oh-mainline )

Note that calculating the project name within the bug importer is essential to fixing a problem where http://openhatch.org/search/ lists many tasks as being within "GNOME Bugzilla". (Those are supposed to use a custom bug parser, but that custom bug parser's project name was being ignored.)

So, the questions really for this review are:

* Is this a reasonable way to add scrapy as a dependency?

* Do we agree that bugimporters/items.py is a reasonable spec for what data gets passed out the data_transit ?

* Do we agree on ditching bite_size_bug_name? (BTW, that column was recently deleted from oh-mainline, so I think that's a fine plan.)

If so, please give me an ACK (: