nicolasff/phpredis — pull request #186 by michael-grunder (2012-05-21 05:07:24+00:00)
Title: EVAL and friends

Hey,

Thanks for having a look through the code. I think I sorted all of items you mentioned.

* ```validate_script_directive``` had actually been removed in a later commit, as I switched it to ```if...else if..else``` logic
* The memory leak in the ```SCRIPT``` command was also fixed on a later commit from the one you commented on.
* I left the exception in ```unserialize``` for now, but I don't have a strong opinion either way. The only real issue I see if we don't throw is how the user could distinguish an error from ```$redis->unserialize('b:0;')```

Let me know if I missed anything, and thanks again! :)

Cheers,
Mike