joeshaw/py-statsd — pull request #1 by thraxil (2012-05-17 15:13:09+00:00)
Title: make server script name consistent with configs

This is to make it consistent with `init/pystatd.conf.upstart` and `init/pystatd.default`.

There are a bunch of inconsistencies with "pystatd" vs "pystatsd". The python code is always `pystatsd`, but the upstart conf files that get set up are `/etc/init/pystatd.conf` and `/etc/default/pystatd` so it implies that the debian service that runs is `pystatd`, not `pystatsd`. Still, the existing `/etc/init/pystatd.conf` tries to start `/usr/bin/pystatsd-server` rather than `/usr/bin/pystatd-server` and gives an error by default.

I think the right solution is probably to standardize on "pystatsd" everywhere. I made this change as just renaming the `bin/pystatsd-server` script to `bin/pystatd-server`, which is the opposite of that because it was the smallest change I could make to fix the immediate problem with the upstart config being broken.

If you'd rather go with the (IMHO) better approach of standardizing on "pystatsd", I'd be happy to put together a pull-request for you going that way instead.