xbmc/xbmc — pull request #971 by anssih (2012-05-16 23:41:24+00:00)
Title: Add graceful checks to avoid hitting several AE asserts

CSoftAE will assert when trying to create a stream with an empty layout or with raw stream type but without specified encoded sample rate, but these cases weren't actually checked anywhere.

These commits fix those issues by adding checks in dvdplayer and paplayer for those cases, and by adding notes in AE documentation that these need to be checked by the caller.

Note: I would've preferred that MakeStream() would check these things itself and bail out gracefully, but @DDDamian insisted that it isn't its responsibility. Do you agree with him?
If not, I will redo the patchset with my preferred solution of checking these in AE MakeStream() instead.