shurizzle/ruby-fifo — pull request #2 by samwho (2012-05-13 14:59:45+00:00)
Title: General library improvement

Hi shurizzle,

I've been hacking on your Ruby Fifo library a bit and made it a lot more idiomatic Ruby, created a testing suite, given it a gemfile, tested it on Travis-CI, documented the code and created a much nicer README.

If you want to merge the changes in and maybe release a new version then please be my guest. If you don't like my changes then by all means don't accept them :) I'll keep my fork open either way.

I haven't tested my changes in Windows as I don't run a Windows machine normally. You would need to test these changes, the testing suite will help. I don't think I've broken anything ^_^

Also note that I couldn't get the mkfifo library to install under ruby 1.8.7. Something about not being able to find the ruby/ruby.h file while compiling. Here's the full error:

Installing mkfifo (0.0.1) with native extensions
Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.

/home/sam/.rvm/rubies/ruby-1.8.7-p357/bin/ruby extconf.rb
creating Makefile

make
gcc -I. -I/home/sam/.rvm/rubies/ruby-1.8.7-p357/lib/ruby/1.8/x86_64-linux -I/home/sam/.rvm/rubies/ruby-1.8.7-p357/lib/ruby/1.8/x86_64-linux -I. -fPIC -g -O2 -fPIC -c mkfifo.c
mkfifo.c:1:23: fatal error: ruby/ruby.h: No such file or directory
compilation terminated.
make: *** [mkfifo.o] Error 1

Gem files will remain installed in /home/sam/.rvm/gems/ruby-1.8.7-p357/gems/mkfifo-0.0.1 for inspection.
Results logged to /home/sam/.rvm/gems/ruby-1.8.7-p357/gems/mkfifo-0.0.1/ext/gem_make.out
An error occured while installing mkfifo (0.0.1), and Bundler cannot continue.
Make sure that `gem install mkfifo -v '0.0.1'` succeeds before bundling.