richlowe/gcc — pull request #10 by richlowe (2012-05-14 00:04:38+00:00)
Title: Cleanup of Illumos 4.4.4 diffs

Hey @wesolows, @jclulow.

I did yet another pass through the GCC diffs we carry, and spotted a couple of embarrassing errors, and some bits we can just in general cleanup. I'd like a 2nd and third opinion.

Keith, especially.

`-fconstant-pools` was added in the service of emulating `-Wu,no_got_relocs` we don't actually use that though! (I've grepped the build, and I've built with this GCC, and thus would fail if we tried to use it). It seems slimly possible that the bug is, in fact, that we should be using that flag, and you're the only person who'd know, so I'd appreciate an opinion.

I'd follow-up with a change to remove the `-Wu,no_got_relocs` in `cw`, when I update the webrev for GCC4 support in general.

The other changes are self-explanatory, I hope. When rebasing these changes onto whatever newer GCC, when that happens, the changes that vanish entirely will be dropped, to cleanup the current mess.