timlau/FedoraReview — pull request #13 by leamas (2012-05-10 18:29:28+00:00)
Title: Just a heads-up...

... that I spent some time on this. Here is a few bugfixes, and sketches to changes. I would not merge this as is, but I would like to share. I also ask you to consider the first commits for inclusion, I think they are stable enough.

Most patches have reasonable comments in them. The unsorted overview:
- New checks: rpmlint on installed package.
- Revised check: licensecheck after %prep, in BUILD area.
- Revised check: runs diff -r on md5-sum mismatch
- Revised check: requirements check produces attachments with provides/requires
- New option --prebuilt, use already existing rpms, with many limitations
- Bugfix: rpmlint check
- Behaviour: use rpm2cpio instead of rpm -i, don't mess with users SOURCE dir.
- Behaviour: Only run rpmlint once, more condensed output
- Behaviour: use rpmdev-extract, handles all sources rpmbuild handles.
- Behaviour: Attachments, larger texts moved out of main report to the end.
- Infrastructure: Settings singleton, holding both config file and cpmmand line options

In the end, my report looks like this:

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
Note: Using prebuilt rpms
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[ ]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking original sources for licenses Licenses found: "*No
copyright* UNKNOWN", "GPL (v2 or later) (with incorrect FSF address)",
"GPL (with incorrect FSF address)" For detailed output of licensecheck
see file: /home/mk/src/FedoraReview/src/licensecheck.txt
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[ ]: MUST Package installs properly.
Note: Using prebuilt rpms
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[!]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Latest version is packaged.
[ ]: SHOULD Package does not include license text files separate from
upstream.
[ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SHOULD Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0: http://downloads.sourceforge.net/faces-project/faces-
pm-%{version}.tar.gz (faces-pm-%{version}.tar.gz) Patch0: python-faces-
openerp.patch (python-faces-openerp.patch) Patch1: python-faces-
version.patch (python-faces-version.patch) Patch2: python-faces-fsf-
fix.patch (python-faces-fsf-fix.patch) Patch3: python-faces-
timescale.patch (python-faces-timescale.patch)
[x]: SHOULD SourceX is a working URL.
[ ]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[ ]: SHOULD %check is present and all tests pass.
[ ]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Rpmlint
-------
Checking: python-faces-timescale-0.11.7-2.fc18.noarch.rpm
python-spiffgtkwidgets-0.2.0-2.59a713f.fc16.noarch.rpm
python-faces-0.11.7-2.fc18.src.rpm
python-metapie-0.11.7-2.fc18.noarch.rpm
python-faces-0.11.7-2.fc18.noarch.rpm
python-spiffgtkwidgets-0.2.0-2.59a713f.fc16.src.rpm
python-faces-timescale.noarch: E: changelog-time-in-future 2012-05-11
python-faces.src: E: changelog-time-in-future 2012-05-11
python-metapie.noarch: W: spelling-error Summary(en_US) wxpython -> Python, python
python-metapie.noarch: W: spelling-error %description -l en_US wxpython -> Python, python
python-metapie.noarch: E: changelog-time-in-future 2012-05-11
python-faces.noarch: E: explicit-lib-dependency python-matplotlib
python-faces.noarch: E: changelog-time-in-future 2012-05-11
6 packages and 0 specfiles checked; 5 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint python-metapie python-faces-timescale python-spiffgtkwidgets python-faces
python-metapie.noarch: I: enchant-dictionary-not-found en_US
python-metapie.noarch: E: changelog-time-in-future 2012-05-11
python-faces-timescale.noarch: E: changelog-time-in-future 2012-05-11
python-faces.noarch: E: explicit-lib-dependency python-matplotlib
python-faces.noarch: E: changelog-time-in-future 2012-05-11
4 packages and 0 specfiles checked; 4 errors, 0 warnings.
# echo 'rpmlint-done:'

Requires
--------
python-faces-timescale-0.11.7-2.fc18.noarch.rpm:
python(abi) = 2.7
python-faces = 0.11.7-2.fc18

python-faces-0.11.7-2.fc18.noarch.rpm:
python(abi) = 2.7
python-cheetah
python-matplotlib
python-matplotlib-wx
python-metapie = 0.11.7-2.fc18

python-spiffgtkwidgets-0.2.0-2.59a713f.fc16.noarch.rpm:
hippo-canvas-python
pygtk2
python(abi) = 2.7

python-metapie-0.11.7-2.fc18.noarch.rpm:
python(abi) = 2.7

Provides
--------
python-faces-timescale-0.11.7-2.fc18.noarch.rpm:
python-faces-timescale = 0.11.7-2.fc18

python-faces-0.11.7-2.fc18.noarch.rpm:
python-faces = 0.11.7-2.fc18

python-spiffgtkwidgets-0.2.0-2.59a713f.fc16.noarch.rpm:
python-spiffgtkwidgets = 0.2.0-2.59a713f.fc16

python-metapie-0.11.7-2.fc18.noarch.rpm:
python-metapie = 0.11.7-2.fc18

MD5-sum check
-------------
/home/mk/src/FedoraReview/src/faces-pm-0.11.7.tar.gz :
MD5SUM this package : eea3cd8dc7f201ac6d745fe9d34274cd
MD5SUM upstream package : eea3cd8dc7f201ac6d745fe9d34274cd

Generated by fedora-review 0.2.0git
External plugins: