silverstripe/sapphire — pull request #418 by halkyon (2012-05-09 10:57:17+00:00)
Title: Fixing phpunit.xml support, remove PHPUnit 3.4 support

I've made a fix to get phpunit.xml working, but the change requires PHPUnit 3.6+ (see https://github.com/silverstripe/silverstripe-installer/commit/21dda5f304aac7c99f704d43daed2972ce48fd92)
The problem was a thirdparty test was being included, but the `` node in the phpunit.xml only works in PHPUnit 3.6+ so we have to require that version as a minimum for running tests with the config file.

This pull request also removes the workarounds for `assertType()` which is directly replaced with `assertInstanceOf()` in PHPUnit 3.5, and `assertEmpty()` workaround for PHPUnit 3.4. This effectively cuts support for PHPUnit 3.4.

PHPUnit 3.4 is quite old now, so we don't need to support that version any longer. PHPUnit 3.6 has been in the wild for a while now, and upgrading from 3.5 is easily done with `pear upgrade phpunit/phpunit`. The differences between 3.6 and 3.5 aren't nearly as big as 3.5 from 3.4.

Tests using `php framework/cli-script.php dev/tests/all` *should* work with PHPUnit 3.5+ still, but running "phpunit" in the root of the project using the phpunit.xml file now requires PHPUnit 3.6.