kennethreitz/requests — pull request #597 by mponton (2012-05-08 15:05:09+00:00)
Title: ```chunk_size``` for ```iter_lines()``` versus ```iter_content()```

Seriously, I think you should merge this one. The latest release and the ```develop``` branch still have the default ```chunk_size``` "reversed" for ```iter_content()``` and ```iter_lines()``` contrarilly to what you mentioned here: https://github.com/kennethreitz/requests/pull/589#issuecomment-5567553

This pull request may be canned by Travis CI again, but as I mentioned in the above pull request, the issue is located either in the test logic or the way lines ending in ```\r\n``` in ```iter_lines()``` depending how you interpret the issue... (I think the later is the real problem as even without changing ```chunk_size```, ```iter_lines()``` could return different results for the same input depending on where the line-ending ends inside the buffer read by ```iter_content()```). Not knowing how you perceive the issue, I did not attempt to fix it.

----- Original idea:

Following discussion about issue #539 Kenneth agreed that a default
```chunk_size``` of 1 for ```iter_lines()``` would make more sense, but
apparently changed ```chunk_size``` for ```iter_content()``` by mistake
instead, which did solve the ```iter_lines()``` issue but also changed the
default ```iter_content()``` chunk to 1 bytes which is not desirable.