fernandezpablo85/scribe-java — pull request #266 by leleuj (2012-05-05 11:47:54+00:00)
Title: Add WordPress support

Hi Pablo,

I try to add WordPress support, but I encounter some problems to make it work with default OAuth20ServiceImpl and DefaultApi20 classes.
So I choose to make a major change in the getAccessToken method to handle more cases and I add customizable "options" in DefaultApi20 : getAccessTokenParametersVerb and isGrantTypeRequired. Their default values make everything backward compatible.

I was also expected the GitHub support to be merged in Scribe, but I saw that the pull request #144 has been closed and you talked about some OAuth 2.0 refactoring I haven't seen in the code yet.
For GitHub support, I can follow the same idea : a new "option" in DefaultApi20 with a default value that makes everything backward compatible (For example, a isCallbackUrlRequiredWhenOOB method with returns true by default) and a specific behaviour in OAuth20ServiceImpl to handle this "option" (add callback url if isCallbackUrlRequiredWhenOOB returns true).

Just let me know if you think I'm in right direction : if it's the case, I could add the GitHub support the same way...

Thanks.
Best regards,
Jérôme