puppetlabs/puppetlabs-nova — pull request #103 by jtopjian (2012-05-05 23:15:00+00:00)
Title: nova-volume modifications

This is a bit of a major change, so do let me know if anything needs clarified or if something should be done differently.

The first change is the modification of the original `volume.pp` manifest. I only left the service declaration in this file. All other information was moved to `volume/iscsi.pp`. My reasoning for this is that others could add support for future volume drivers -- for example, `volume/sheepdog.pp`.

Next, the original volume implementation only used file-based LVM. I tried to add support for real LVM support while still keeping the ability to use file-based LVM.

Finally, I added relevant tests and example declarations.

This commit has only been tested in my environment, so I am aware that there might be issues.