symfony/symfony — pull request #4205 by Tobion (2012-05-05 00:26:57+00:00)
Title: [Routing] fix encoding of static static

BC break: no
Fixes #4166

The first commit shows simply what the problem is: The chars, in this case `"`, get encoded when part of a placeholder but not as static text. This makes it inconsistent and can produce invalid URLs.
The second commit fixes the issue and further enhances the test with more chars. It also adds chars that do not need to be encoded for better usuability (explained in code). Some people people might want to use chars like `+` in the path and it looks better when its not encoded and it doesn't change anything semantically (it generates the same url, but is easier to read).
The third commit fixed a phpDoc issue (not using inheritDoc and the setter was marked with @api but not the getter).