flatiron/nconf — pull request #38 by russfrank (2012-05-02 03:34:11+00:00)
Title: Fixes to `nconf.save()`, additional tests

`nconf.save()` now saves asynchronously when given a callback. It also returns whatever data was successfully saved. Previously, when it was run without a callback, it would have this behavior; I assumed this meant that the behavior was desired when saving asynchronously, as well.

I removed the `value` parameter, as it was ignored anyway. I'm not sure what the intent of the original documentation for this function was, to be honest.

I also removed the tests which expected `save()` to throw or return an error when the memory provider is used.

The second commit adds a new test, `complete-test.js`, which attempts to be a more complete functional test.

This request addresses issues #37 & #29.