doctrine/doctrine2 — pull request #343 by rivaros (2012-05-01 18:50:19+00:00)
Title: Lets make correct data structure

Dear all,

As you know Doctine2 supports explicit quoting of identifiers.

This is extremely useful for PostgreSQL where "TableName" and TableName(implicit lowercased) are 2 different things. That's why - please, do support explicit quoting with ` (back-ticks) in future.

Now a problem - you do not support quoting columns which are part of associations. Can you give me a reasonable answer why it should not be supported?

Now comes my first update - i think that keeping "quoted" property inside the fieldMapping array is globally wrong. "Quoted" is a property, related to a column, not field. For example, an association can consist of 2 joined columns, and 1 of them can be quoted (theoretically).

That's why a better choice to store "Quoted/Nonquoted" properties in ClassMetadata level. I made an array quotedColumns for this and rewrote the function getQuotedColumnName to use it.

If you have time for short dispute, I may have a solution to make explicit quoting supported in join columns.

See related thread here:
http://www.doctrine-project.org/jira/browse/DDC-142

Last comment was
"After some discussion support for quoting join column names and discriminator column names has been dropped for the sake of simplicity.
Quoting table names and regular column names will continue to be supported.
The docs have been updated accordingly."

I can argue on this - my solution is even more simple.