cgeo/c-geo-opensource — pull request #1467 by rsudev (2012-04-29 12:15:58+00:00)
Title: Issue1308a

So finally a new proposal for the mapsforge 0.3.0 integration. It consists of two commits, one for the switch to mapsforge 0.3.0 and one for the integration of 0.2.4 offline maps, so the first can be applied without the second if it is wanted.
I prepared this second commit as I was already nearly done with it when the discussion here converged on a breaking change and I spoke with some users I know and got the impression that a substantial portion of them would probably miss this change and be out caching the next time without a working map.
Therefore I added a prominent 'Deprecated' toast to the 0.2.4 offline map view.
Another thing I struggled with quite some time was the fact, that I could not implement the offline-without-valid-mapfile behaviour we just introduced. There seems to be no way to make the 0.3.0 map work without a mapfile in offline mode. I filed an issue for that at mapsforge, so this may get sorted out probably, but until then the map will just crash.

Comments, critics, etc very welcome!

Unfortunately I did not really receive any reviews on the actual code. I tend to assume that either nobody had the time to really take a look or there where no objections.
Therefore I will merge it myself tomorrow if nobody says 'wait' or 'stop'