sakaiproject/nakamura — pull request #759 by mrvisser (2012-04-24 12:44:40+00:00)
Title: KERN-2796 Migrated basiclti widget displays ltisecret cannot be null (500)

The bug was that we read the import JSON of the page as a regular user to perform the migration, which will miss the ltiKeys node. That is fixed in this commit, and also I've re-locked the ltiKeys node AFTER we have migrated it as no ACL info is migrated.

I think the re-lock mechanism is a bit hacky, in the sense that the DocMigrator shouldn't necessarily directly know anything about "basic lti" widgets and their permission requirements, but the alternative is to implement a listener interface for our JSON importer (similar to MoveCleaner), which would require more changes at a much larger scope than I think we should be making at this point in 1.2.0.