freerange/sauron — pull request #25 by floehopper (2012-04-24 12:28:00+00:00)
Title: Tweaks to team-related functionality.

I think I've got a few ideas tangled up in here and this commit may not
be the best representation of them, but here are the things I'm getting at
roughly in order of the importance I attach to them :-

- Importing messages for a single account or multiple accounts should
not be such a special case - I can (just about) see the justification
for separate rake tasks, but essentially a single account would be
better represented as a one-person team. I haven't completely
addressed this, but have made some progress towards it.
- I think it's better to separate the concern of parsing of environment
variables from the `Team` model. And I prefer if tests don't have to
mess with real environment variables - I prefer that this is just done
in the rake tasks - although I realise that with my current changes
none of the tests (not even the Cucumber tests) are testing with the
real environment variables. Maybe the latter is taking things too far,
but you could also argue that we are not calling the real rake task
here either.
- Now that we have a real `Team` class, I don't think it makes so much
sense to stub the `each_member` method in `TeamMessageImporterTest`.