phpmyadmin/phpmyadmin — pull request #41 by alexukf (2012-04-20 14:43:59+00:00)
Title: bookmark sql query after checking errors

When running an sql query, if you select to save the sql bookmark, this will be saved even if the query you introduced contains errors.

I think that you would not necessarily want to save the bookmark if it's not valid, because you will still have the initial query you introduced in the 'Run SQL query' section, thus being able to edit and save that one to your bookmarks.

This avoids the situation when you try to save a bookmark, realize you have a syntax error, edit the query and save again, and then end up having two bookmarks with the same name. I would say this is a realistic scenario because if you have an error, your first thought is to fix it and try again, forgetting about the 'Replace existing bookmark' option.