buildbot/buildbot — pull request #385 by Jc2k (2012-04-20 00:26:53+00:00)
Title: Slightly decoupled ForceScheduler

The main aim of this change was to allow me to subclass ForceScheduler and run additional "smarts" before a build was queued. This accomplishes that and takes a step towards a more decoupled ForcedScheduler based on discussion in IRC.

For me, I can subclass and extend gatherPropertiesAndChanges or I can use a Parameter class (now that they can use deferreds).

For every one else, the scheduler no longer requires a request object. The IRC bot could now be refactored to do something like:

sched.force("Jc2k", "builder_name", someprop="hello", somepro="woo", ...)

And the defaults and validation set on the ForceScheduler would be used.

Ideally I would change the builder_name and owner params around - they are only that way round to match current implementation.

The logic for owner is wrong too - thoughts on that would be appreciated.

Tests pass, however.