nyetsche/core — pull request #2 by nyetsche (2012-04-18 21:05:30+00:00)
Title: added mount_opts call for a non-fstab edit mount

This was previously requested as a 'pull request', although it was to my master branch, which was complicating things. The branch/patch should be clean and clear and was rebased off the upstream origin/master.

From the original pull request:

This issue was first presented as a bug here: https://cfengine.com/bugtracker/view.php?id=997

This is my attempted fix; note that the options line is hardcoded (line 534) as '-o %s', with %s set ultimately to a.mount.mount_options, with ',' as delimiters. If there if UNIX system that does not use the format 'mount -o opt1,opt2', this command will not work correctly.

with commentary by 'dottedmag':

Thanks for fixing that. A couple of nitpicks:

please rebase this pull request against the fresh upstream branch (git rebase upstream/master, substitute upstream for the remote for the git@github.com:cfengine/master), this will get rid of 4 merge commits.

please reword the commit message so it fits in 80 symbols (see the http://progit.org/book/ch5-2.html#commit_guidelines )

Note that there might be a request to sign contributor agreement on this change, I'll get to you back soon if it is the case.

Is that last statement still correct?