GalSim-developers/GalSim — pull request #106 by rmjarvis (2012-04-12 15:44:31+00:00)
Title: #81

I ended up doing a bit more with this issue than just removing the "GS"'s.

- I didn't like the constructor for Add. It took an SBAdd object, which should be an implementation detail, not the interface to expose to users. So I made its constructor work like Convolve, taking a list of GSObjects that should all be added together.

- Doing this (and changing how DoubleGaussian was implemented to use the new constructor), I discovered two bugs in SBAdd, which I fixed.

- Along the way, I made the python test scripts in the tests directory runnable singly, rather than just via nose, since I just wanted to run test_atmosphere.py. And also not have nose suppress the print statements.

- I also adjusted Demo.py. Mostly to showcase the new Add functionality. It now adds two _separately sheared_ Gaussians, rather than two circular Gaussians via DoubleGaussian and then shearing the result.

- I added a few more output lines to Demo.py, which shows better where it is slow. It's pretty clear that Joe is right that it is primarily from the Poisson noise. Not Barney's Optical PSF stuff. However, I suspect that might be a bit of a red herring. It's also the case that the size of the image gets significantly larger for script 2 and then moreso for script 3. So adjusting the size to be 128x128 for all three may give a fairer impression of what needs to be sped up.