baudehlo/Haraka — pull request #178 by godsflaw (2012-04-11 22:48:19+00:00)
Title: Heavy rewrite of smtp_proxy and smtp_forward to use new smtp_client pool

This commit removes the old conn_pool_base.js and related tests for a more common smtp_client.js in the core server. smtp_proxy and smtp_forward are now written against this new smtp_client module, and are well tested in production and unit tests.

A bug in connection.js where close was not being caught is now resolved by catching close and calling the same common routine as end.

Fixed a typo in the aliases docs.

Added the dependency generic-pool, which is needed for the pooling core of smtp_client.js.

cherry-picked the disconnect hook patch from _smf_, but for some reason that should not show up in the diff. This may or may not produce a conflict when merged.

Sorry for the huge diff Matt.
Test that used to use the tap interface are now re-written to use nodeunit.