mozilla/socorro — pull request #497 by twobraids (2012-04-11 16:58:52+00:00)
Title: added crashstorage for filesystems

the new file is `.../socorro/external/filesystem/crashstorage.py` and should be reviewed. The unittests are in the expected `.../socorro/unittest/external/filesystem` and should also be reviewed.

It is not necessary to review the support files that live in directory with crashstorage.py. We know these files are a mess, but we also know they work. It is outside the scope of this crashstorage project to rework the support files.

The rest of the changes in this commit are rearranging filesystem support files into more appropriate directories. The support files for file system storage have been in `.../socorro/lib` and are now in `.../socorro/external/filesystem`. A parallel change was made for the unit tests, too. This code will have a phased in deployment. As such, old code and new code will have to coexist. I wanted to minimize changes to old code, so when I moved and renamed the filesystem support files, I left symbolic links at the old locations. That means that old code won't notice that the support files have changed location, the git history of those files is preserved in the new location, and we don't have actual duplication of code. When the old code is retired, then the symbolic links can just be deleted.

BTW, I made sure that git handles symbolic links properly before embarking on this change.