puppetlabs/puppet — pull request #640 by stschulte (2012-04-07 23:06:04+00:00)
Title: (#13679) Skip variable interpolation on dbpassword setting

when puppet reads `/etc/puppet/puppet.conf` it does variable interpolation
when receiving a setting. The convert method that is involved here does
not allow for escaping/quoting or any other mechanism to stop variable
interpolation. While most settings do not allow a dollar-sign anyways
the dbpassword may legally include one.

I'm not sure if we need a general escaping mechanism or if we should just skip value interpolation for different settings. I'm afraid that introducing quoting and esacping in `/etc/puppet.conf` would both make the parser and the file itself needlessly complex for a single usecase. In my opinion `dbpassword` is the only setting that may legally include a dollar sign and I cannot come up with a usecase where you do want to have value interpolation on `dbpassword`. So the fix attached in the branch field just skips validation on `dbpassword`.

But I'm happy to hear different opinions.