emacs-helm/helm — pull request #35 by tarsius (2012-04-03 19:59:16+00:00)
Title: helm-map: use substitute-key-definition

You keep merging my changes so I have to try...

This commit changes `helm-map` to use `substitute-key-definition` where it makes sense and rearranges the definitions.

I cannot test this myself as I use highly customized key bindings though. Also you might not like that lines get rather long. Certainly still needs more work - more a suggestion than a pull request at this point, I guess.

I don't understand this:

(define-key map [f1] nil) ; Allow to eval keymap without errors.

Also are these additional bindings necessary?

(define-key map (kbd "C-o") 'helm-next-source)
(define-key map (kbd "") 'helm-scroll-other-window)
(define-key map (kbd "C-M-y") 'helm-scroll-other-window-down)
(define-key map (kbd "") 'helm-scroll-other-window-down)