enyojs/enyo-1.0 — pull request #12 by pcworld (2012-04-01 13:14:28+00:00)
Title: Hack: Support for Sym key on webOS phones

See https://developer.palm.com/distribution/viewtopic.php?p=99934#p99934

In my opinion, this code shouldn't be in the official repo, but I made this pull request as Ben Combee asked me to do so.

Reasons *against*:
- enyo.fetchDeviceInfo is called to figure out if the device is a phone. If this function is called every time the framework is loaded, the device data should be a global object, and not be parsed every time we need device data.
- My "hack" uses the OS version to figure out if the device is a phone. This is bad style.
- keyCode is checked for a specific number instead of a global variable defining the keyCode for the sym key
- sets vars/function on the window object
- sets enyo.windowParamsChangeHandler; if this function would be used elsewhere in the framework, this hack would break it
- The symbol keyboard that pops up by calling "showAltChar" on a service is not nearly as mature as the Mojo one was. I.e. you can't press keys to jump to a section or to immediately write e.g. umlauts.
- This kind of code and in this place of a file is really bad design

The only reason accepting this pull request would be that Enyo 1.0 isn't officially supported anymore.