silverstripe/sapphire — pull request #275 by halkyon (2012-03-27 08:20:21+00:00)
Title: First round of fixes for E_STRICT compliance

Getting E_STRICT working is quite difficult ;-) So I thought I'd break it up a bit, and provide chunks of fixes at a time. This round gets sapphire mostly up to scratch, minus the late static binding fixes to get DataList::create() and ManyManyList::create() of the same argument signatures (@ajoneil is taking care of that in pull request #273).

The other problem area is DBField::hasValue(), as ViewableData::hasValue() has quite a different argument signature. It doesn't make much sense copying the arguments from ViewableData::hasValue() to DBField. That is to be solved another day.

Hierarchy::augmentSQL has an argument of DataModel (2nd argument) which isn't the same as the parent DataExtension::augmentSQL which doesn't have it. I removed it from Hierarchy and all the tests seem to pass still. I couldn't find this argument in 2.4 either, so not sure why it's there.