TrinityCore/TrinityCore — pull request #5902 by Warpten (2012-03-26 19:50:19+00:00)
Title: Core/Spells: Periodic dispel effects broken

Issue: Periodic dispel effects (like Abolish poison and Abolish disease) were removed after the first tick of their periodic effect. Those spells, when cast, where returning SPELL_FAILED_NOTHING_TO_DISPEL in Spell::CheckCast(bool), causing the aura to be removed.

Fix description: This commit adds a check that ensures that only spells with power cost will return SPELL_FAILED_NOTHING_TO_DISPEL. I made it this way because both Abolish Poison and Abolish Poison's periodically trigerred spells do not have a triggered flag.

Been tested ingame, working, and no counterpart detected. Still looking for some better way though.