mendicant-university/liskov — pull request #22 by sandal (2012-03-26 01:35:57+00:00)
Title: Add authorship to discussions and basic gravatar URLS

Hi Jordan, we aren't ready to merge upstream yet, but I wanted to do an interim review request just so that we can learn a few things and roll in some of your suggestions before we do merge.

Jia and I have worked on making it so discussions can be associated with an author. To do this, we ended up having to do a bit of gravatar integration (commit: b55c4) and refactoring of PersonDecorator (commit: 2307b), but we made those changes on master because they seemed to be generally useful.

After making those changes, we updated the code on our feature branch to implement authorship and gravatars, as shown by the screenshot below.

![](http://i.imgur.com/O234g.png)

I left a few questions for you inline on commit 0c02f, but would be happy to hear any other feedback you have as well.

NOTE: In order to run this code it is necessary to update any discussions from our original seed data using something like:

```ruby
Discussion.all.each { |a| a.update_attribute(:author, "sandal") }
```

We plan to add very simple discussion CRUD before merging, and delete the db/seeds.rb file. But I figured I'd let you know about this gotcha in the interim.