tarnacious/text-invoice — pull request #1 by scottlowe (2012-03-25 10:52:56+00:00)
Title: I hope you don't mind a little feedback, yo.

Tarn!

I saw the long list of `if...elsif...elsif` conditionals and couldn't ignore it. Like picking at a code scab! I altered the code, but I've not generated and invoice; however, the specs passed just fine.

Also some of the spacing and tabs are off in a number of files, e.g. here:

https://github.com/tarnacious/text-invoice/blob/master/lib/text-invoice/template.rb

The Ruby community tends to favour the use of soft-tabs with a two space indent – I didn't fix these.

GitHub's Ruby style guide is here (it tends to reflect community conventions, anyway):

https://github.com/styleguide/ruby

Anyhow, enough of the critique – Well done! You've published more gems than I have ;-)

Scott