ViennaRSS/vienna-rss — pull request #32 by TheSpyder (2012-03-26 05:18:21+00:00)
Title: Multiple article open fix

Somewhere in the 2.6 release a bunch of code was added to support multi-selection in the item list, and opening them all when pressing enter.

The function to actually invoke the URLs is big and complicated, with timeouts and retries etc. This is not only unnecessary (the NSWorkspace openURLs function takes an array), it ignored the "open links in external browser" preference.

I've patched array support into the functions that wrap up the external browser preference, and removed the unnecessary code in favour of them.

The only think I'm not sure about is the call to markReadByArray - it used to be conditional on the URLs opening successfully, now it just happens. The NSWorkspace method returns a BOOL, I can flow that through and check it before calling markReadByArray if you want.