jverkoey/nimbus — pull request #182 by NukemHill (2012-03-25 22:55:46+00:00)
Title: Refactoring of NimbusPhotos, etc.

Ah. I think I've figured this out. I read the link Roger gave me about pull requests weeks ago, but for some reason it didn't click what was going on and how easy this actually is. I think I was too wrapped around the axle regarding how it was "supposed" to look in GitHub for Mac. Plus, I hadn't forked the code at that point.

I've got a fork of nimbus that I've been working on. I have refactored several files in the NimbusPhotos module, and adopted the data source model as discussed in #151 by @vgrichina. It seems to work well, and I've rewritten the Facebook and Dribbble examples to take advantage of this. I am also in the process of writing a CoreData model/datasource and example, and the development cycle seems to be pretty straight-forward.

I have also added a couple of classes to NICellFormCatalog in NimbusModels. I created NITextInputFormElementCell2, which displays the label for a cell in the left view of the UITextField.

I would like to open a discussion that NICellFormCatalog should probably be refactored, the individual classes be pulled out, and everything be restructured in a Factory or AbstractFactory Design Pattern. I just think it makes more sense, and makes extending the code easier. At least, in my experience, using factories in this type of situation seems to make sense.

I've opened an "issue" in #174. I'll continue the discussion there.

Let me know what you think of all of this. If you need more documentation wrt the new code I've added, let me know. I'm not great at documenting code, so I'm never sure what is needed.