rhodes369/rhodes-ror — pull request #79 by doktorj (2012-03-24 16:15:46+00:00)
Title: newly crafted search should now be working more cleanly with all filters, image place holder +

also just spent most of the night / morning refactoring out the newly_crrafted_without_images scope, which was a major change! we gotta watch out for misunderstandings or miscommunications on stuff like this, since i spent a long time writing, then refactoring multiple times to get it as clean/solid as possible to have the no_imaged products not show. re-writing it later took significantly longer because i had to basically take a significant part of the engine apart and put it back together again using new pieces : ) great learning experience, but took a long time.

- newly crafted search section now needs much testing to make sure it's functioning properly and with each filter together... these will be great for unit test additions later, but until we have them flowing, we gotta test this by hand/browser

- once we agree, that the newly crafted search/filter section is all working fine and dandy with all filters at once, or no filters (including making sure it loads all on initial page load), then i will get the antique filters working, which i'm estimating should take signifncantly less time.

- so eph if you get a chance please test away and let me know of any bugs, which i'll attempt to fix tonight, and ideally get the antique section working tonight too.

- also, i really gotta sleep, but realized it would be way easer for you to work today probably (if that is in your flo) off master branch...so i did many local backup branches and testing on test branches, before realizing that the entire fresh search branch would merge into master without conflict - so sweet - we can now go back to doing our usual pull requests.

have a good day.
j