cgutteridge/Graphite — pull request #9 by CloCkWeRX (2012-03-22 22:52:35+00:00)
Title: Further test coverage & bug fixes

I'd suggest doing pull request #8 so it's a bit cleaner to review this.

From 2d79a035	onwards, this is a series of unit tests covering methods, and bug fixes only where a bug has been exposed by the test.

54b7fc3c and e655f155 fix the Graphite_Literal::__toString() regression.

You'll probably look at the unit tests and think some are unrealistic scenarios or edge cases. I'm still intending to add more coverage, but if there are any wrong or missed expectations please let me know.

Locally, all of the tests pass for me (php 5.3).
However on http://test.pear.php.net:8080/job/Graphite%20(experimental%20package)/4/console (Approx PHP 5.4 RC1?) there's one test failing which confuses me.

Coverage is up to 33.78% of all lines with these changes.