rails/rails — pull request #5557 by carlosantoniodasilva (2012-03-23 03:49:02+00:00)
Title: Fix build for branch 3-2-stable

These changes should fix the build for 3-2-stable branch.

The failures are happening due to the change from 1.8.7-p352 to 1.8.7-p358. It includes a change on Hash implementation, making fixtures to be loaded randomly, thus making tests without explicit ordering fail.

After talking to @tenderlove, we decided to skip persistence tests related to UPDATE + ORDER BY for PostgreSQL (there are three). PG does not support updates with order by, and a test is failing randomly depending on the fixture loading order now without a proper way to fix (a possibility would be to force all fixtures to use omap, but the test doesn't make that much sense to run under pg anyway - more ideas are welcome).

I've run both `test_postgresql` and `isolated_test_postgresql` rake tasks several times locally to make sure no other test was failing randomly, however I can't ensure some test won't fail in a near future that my runs didn't catch.

I have also fixes for 3-1 and 3-0 branches, just want to discuss this PR and if applied, make sure it runs green on travis before sending the others.

Let me know if something should be improved.

/cc @nzkoz @spastorino