bitcoin/bitcoin — pull request #962 by Diapolo (2012-03-20 18:23:48+00:00)
Title: fix for number of outbound connections (was limited to 8)

old behaviour:
- if -maxconnections is 0 or negative, no connection to the network was established at all
- the maximum number of connections was in range 0 to 8 (125 was unused)

new behavior:
- if -maxconnections is 0 or negative, MIN_OUTBOUND_CONNECTIONS will be used to ensure connectivity
- if -maxconnections is unset Gavins intended default of 125 is used
- if -maxconnections is > MAX_OUTBOUND_CONNECTIONS, MAX_OUTBOUND_CONNECTIONS is used

Perhaps the value of MAX_OUTBOUND_CONNECTIONS and MIN_OUTBOUND_CONNECTIONS should be refined further.

I tested the changes on Windows and can confirm they work. Oh and I think this "bug" or let's say strange behaviour was introduced by Gavins commit to set defaults to 125. I was so sure, that I saw more than 8 connections before 0.6, but no one seems to have noticed?