concrete5/concrete5 — pull request #463 by jamesshannon (2012-03-20 22:48:54+00:00)
Title: Removed unused code in Page::getCollectionParentIDFromChildID()

I don't understand the purpose $cParentID check in there. Is it supposed to check against the class's cParentID (but it's not doing ->cParentID)? And, if it's supposed to use that if available, then it's not really returning the parent id from the child id...

It's only called twice within my source, both as a static, which would also imply the original programmer wasn't trying check the $this->cParentID. Either way, this pull doesn't change the behavior from today... just makes the code more clear.

Also, added the intval(). Not a bad idea to not trust all developers.