kouphax/sentimentalizer — pull request #1 by garrettheaver (2012-03-12 23:33:15+00:00)
Title: very minor suggestions

Nice one chief!

I made a few suggestions here which might not be in the Sentan whatever way of doing business but you won't see very much Ruby code which leaves objects lying around in class variables so i changed that to be instance based.

I also changed up a few brace style &blocks to use do and end which is more common when you're doing a multiline block but again its more a style thing. Other than that most stuff is personal preference minor type crap, changed src/ dir to lib/ as thats the Ruby standard blah blah blah.

One thing I'll say on quotes / strings in Ruby and its one thing I'm OCD about which most Rubyists aren't really, but literal strings only need single quotes. Double quoted strings are interpolated / any code within is executed...just means I know by looking at the first character if the string contains an interpolation or not.

With regards brackets, there are definitely two schools in Ruby for this and you'll have to run your own heuristics as to which you prefer. More of a use brackets man myself but I can respect the opinion of don't use then unless you have to.

Line 81 of classifier.rb. Not sure if that should be Sentiment::NEGATIVE or Sentiment::NEUTRAL?? Where's your fucking specs bitch?

G