silverstripe/sapphire — pull request #240 by simonwelsh (2012-03-12 20:21:29+00:00)
Title: BUGFIX BASE_PATH was trimming trailing whitespace in paths rather than t...

...railing DIRECTORY_SEPARATORs.

The parentheses were off by one, so DIRECTORY_SEPARATOR was being passed as the case-sensitive parameter to define() rather than the charlist to rtrim(), so really weird edge cases where someone had whitespace at the end of their path mean the include path was set to non-existent folders, so nothing was included.