otwcode/otwarchive — pull request #526 by sarken (2012-03-12 01:53:18+00:00)
Title: Issue 2960 restructuring series edit form

Fix issue 2960 with the series edit form: http://code.google.com/p/otwarchive/issues/detail?id=2960

Reported issues:

1. no legends
2. no landmarks
3. the form labels in the second fieldset have double underlines
4. the Cancel option is a plain text link
5. the character counter is centered under the corresponding input
6. the text fields with character counters do not have Live Validation

Changes in this commit:

1. The legend is included, but you'll have to view the source (per our style, forms with three of fewer fieldsets do not display legends) -- the line you are looking for is
Meta
.

2. The landmark is not included, as it was an experiment on the works form.

3. Form labels now have only one line beneath them.

4. The Cancel option is style as a button.

5. The character counter is now right-aligned.

6. If you go over the character limit, the red Live Validation text will appear.

Additionally:

7. The form is now two fieldsets (grey boxes) instead of three. I did this for two reasons. One, because it corresponds with how the information is displayed. The information provided for Series Title, Author/Pseuds, Co-authors, Add co-authors?, Series Description, Series Notes, and This series is complete, all displays as one group on the series page (the meta box above the stories). Two, because it corresponds with the way forms are laid out elsewhere on the site. The forms for collections and works both put title, authors/owners, summary/description, and notes in a single fieldset.

8. The checkbox now appears to the right of the label 'This series is complete' rather than appearing to the left of the label 'Is this series complete?' It might seem visually counterintuitive, but it tends to work better for assistive technology, and we use this layout in many forms.

Known issues:

1. Ticking the Add co-authors? box does nothing. See Issue 2614.

2. When viewing the form for a series that has a co-author, the 'Current Co-authors:' label has a colon, unlike all the other labels. This will be fixed when the forms are all properly standardized.