chiselwright/catalyst-plugin-errorcatcher — pull request #2 by felliott (2012-03-08 18:00:11+00:00)
Title: Test fix

Hey Chisel,

I rewritten my patch to accept \r?\n instead of just \r\n. Since the $key arg was being quotemeta'd, I couldn't just put a ? in the string. Instead, I changed _has_value_for_key() to not escape $key, and converted the callers to pass regexes instead of plain strings. I hope that's okay, and if not I'd be happy to fix it to whatever you'd prefer.

Thanks for looking at this!

Cheers,
Fitz