antlr/antlr3 — pull request #9 by sharwell (2012-02-22 18:39:24+00:00)
Title: Lots of code cleanup

Primarily fixes build warnings reported by `-Xlint -Xlint:-serial`, with a few additional small (non-breaking) tweaks for clarity.

*Raw types*

* Specify generic arguments on raw types in the runtime (no method signatures change after erasure, no compile-time breaking changes for any end user code which is not specifically using the runtime incorrectly)

*Clarity*

* Add `@Override` annotations
* Remove explicit boxing/unboxing
* Remove unnecessary casts
* Replace explicit `for` or `while` loop iteration over an `Iterator` with a `for each` iteration (except in cases where `Iterator.remove()` is called

*Performance*

* Use `StringBuilder` instead of `StringBuffer`
* Use chained calls to `StringBuilder.append()` instead of using string concatenation within a single call to `append()`
* Iterate over `Map.entrySet` instead of `Map.keySet` when both the key and value are needed