imageworks/OpenShadingLanguage — pull request #113 by lgritz (2012-02-22 14:52:42+00:00)
Title: Review: refactor and debugging aids

A bunch of miscellaneous refactoring and more tools for debugging. (Yet again, turned out not to be a real bug in OSL, but I still want to check in some of the changes I made while debugging.)

The oso reader was ignoring the %mystructfield hint, and thus not marking symbols as being parts of structs. Turns out to be no harm done, but it seems like a good practice to set up the Symbol::fieldid correctly.

ConnectShaders, when it added a connection record, was properly tagging the downstream symbol as connected, but not the upstream symbol as connected_down. Again, turns out that no harm came from this, but it seems sloppy not to set the field so that it's always accurate.

Added "explanations" to make_param_use_instanceval for use in certain debugging modes, also beefed up some of the turn_into_nop explanations to point out which symbol in particular they were concerned with.