TruthMedia/FormBuilder-Development — pull request #36 by outis (2012-02-22 01:45:36+00:00)
Title: Fixes: notices & strict `strpos` return value comparison

The first of the commits changes the various places `strpos` is used to strictly compare the return value to `FALSE`. Otherwise, the code doesn't distinguish the case where the needle occurs at the start of the haystack from the needle not occurring in the haystack. Not distinguishing these cases has various consequences. For example, field values can't be the empty string (e.g. "|none" will be parsed as a field with value "|none", rather than a field with value "" and label "none").

The second addresses minor notices for unknown constants and undefined variables & indices, mostly which clutter up things in development.

The third is another minor update, removing an unnecessary string interpolation.