danielreuther/liferay-portal — pull request #2 by matethurzo (2012-02-21 10:26:52+00:00)
Title: LPS-25393

Hi Daniel,

I've restructured this commit a little bit. Please check it and let me know if you have any questions or considerations.

But let me explain why I did those:

- First I've left the search for the Specification-Version at the first place. The reason is that this has been served the portal for several systems, so I wouldn't remove that. So my assumption is that most systems will stop here.

- Then if needed we will fall back to the Implementation-Version. again if it can be found here the execution will return to the calling environment at this stop.

- then we will fallback to the fedora style packaging (which is not quite common though).

the reason I've added the returns is that if we have a value we will save some ifs. well I'm just thinking now that we shouldn't use the validator since we are sure that the GetterUtil won't return with null. but can we rely on that class' behavior? Never mind.

Please check out the changes and let me know your thoughts you can refuse to go with this solution :) It's just an idea.

Máté