pinax/pinax — pull request #43 by nigma (2012-02-21 23:32:32+00:00)
Title: Let's fix the SignupForm form

The current `SignupForm.save` contains old django-friends invitation handling code and is hard to understand and customize.

I suggest to extract any email confirmation related code to separate method, keep the base form simple and provide legacy `DjangoFriendsSignupForm` or just get rid of that code (currently it is not triggered because no `confirmation_key` is passed to the form from the `signup` view anyway).

I also added `KaleoSignupForm` to the patch as example how easy it is to provide custom email verification method using the new approach.

I include full commit history in case you want to follow my way of thinking and code refactoring steps.