acrmp/foodcritic — pull request #9 by aia (2012-02-21 19:25:13+00:00)
Title: Numeric value for mode should be 5 digits (CHEF-174)

In FC006, numeric value for mode should be 5 digits to ensure that ruby (jruby) parses the mode correctly. I actually run into this one myself with jruby.

As seen in
http://wiki.opscode.com/display/chef/Resources#Resources-CookbookFile
"A note about mode: When specifying the mode, the value can be a quoted string, eg "644". For a numeric value (i.e., without quotes), it should be 5 digits, e.g., 00644 to ensure that Ruby can parse it correctly. For more detail, see Ticket CHEF-174."

Given how working with numbers in Ruby can be tricky, "FC002: Avoid string interpolation where not required" does not sound like a good advice. My rule of thumb - quote unless you are really really sure.