gavinandresen/bitcoin-git — pull request #28 by laanwj (2012-02-18 16:03:31+00:00)
Title: set application identity information before first QSettings

Fix the following:

* Application identity information (setOrganizationName / setOrganizationDomain / setApplicationName) that is used to choose the qsettings location should probably take into account testnet / normalnet, so that those settings don't overlap
* The OptionsModel (which uses QSettings) is constructed before setting the app identity information. I don't think that will work.
* setApplicationName currently depends on the language, as it is run through the translator. If this means that the settings location depends on the language, people will lose their settings when changing language.
* "import_finished" -> "bImportFinished"

I've tested it a bit and at least the GUI settings are remembered.

What doesn't work yet, is the initial conversion of wallet.dat, it gives an error:

************************
EXCEPTION: NSt8ios_base7failureE
CAutoFile::read : end of file
bitcoin in Runaway exception

terminate called after throwing an instance of 'std::ios_base::failure'
what(): CAutoFile::read : end of file
The program has unexpectedly finished.
/store/orion/projects/bitcoin/bitcoin-qt-build-desktop/bitcoin-qt exited with code 0

I don't think the wallet database system works before AppInit2 initialization? We must somehow move this migration to a later point.