cobbler/cobbler — pull request #67 by crobinso (2012-02-14 18:14:41+00:00)
Title: Port koan from virtinst to virt-install command (v2)

Koan uses the virtinst library for creating libvirt VMs. This is the
same code that virt-install and virt-manager use for a lot of their
libvirt interaction.

Problem is this virtinst never should have been a public API, it was
designed without much thought, and attempting to maintain back compat
all these years hasn't really done much good.

On the flip side, virt-install very much is intended to be a stable
API: there are far more people out there using virt-install for scripting
and we plan on keeping those scripts working as long as possible.
virtinst should really be an implementation detail of virt-install.

So along that line of thinking, I want to deprecate virtinst as a public
API, and keep it private to virt-* tools. So here is a patch series
swapping koan from virtinst to generating a virt-install command line.
Ideally this patch makes it into fedora before march so I can deprecate
virtinst in upcoming fedora 17.

In the process, I add unit testing and unify most of the libvirt koan
code, so hopefully things are in a better state than before.

I've tested this with qemu/kvm, xenpv, and xenfv koan installs.