xbmc/xbmc — pull request #686 by jmarshallnz (2012-02-13 07:41:13+00:00)
Title: fix overwrite of a single byte of memory when reading pre-2.4 PIC tags

Pre v2.4 tags use PIC frames for embedded images. These are updated internally by libid3tag to v2.4 APIC frames. In the process, the 3-byte picture identifier (PNG or JPG) is read using id3_parse_immediate, which is passed a 3 byte buffer to read 3 bytes. However, the function also writes to the fourth byte to null-terminate.

Fix is to simply increase the buffer size to 4.

I suspect that this will fix the issues that some have had on IOS with the recent comment change. It is certainly worth testing.

In addition, there's additional issues (though not crash issues) with the comment tag reading, which I'll address with an update to this pull req.