SeanLuckett/StringCounter_kata — pull request #3 by anthonynavarre (2012-02-11 22:04:55+00:00)
Title: Newlines handled, refactored specs, & new spec for custom delimiters

I merged in your "clever" solution - you took the "correct" evolution for this problem.

I also changed up the specs to use a few of Rspec's helper methods - I find the methods like `subject`, `let`, `before` and `its` to allow for less duplication in the specs. I also find that if your code has a code-smell, these formats tend to be more clumsy and painful -- and easier to use once you've gotten rid of the code-smell.

You don't need to stick w/ this format, but it will help to familiarize yourself w/ it and form your own opinion.

...

For this next implementation, same as before -- ugly first. Don't worry about putting your refactor in its own branch this time though. If all the tests pass, go ahead and allow it to live on master. If it needs to be improved and refactored further, we'll do so in a future commit.

Your next ping back to me should force me to implement an error when negative numbers are present.

PONG!