mhan810/liferay-plugins — pull request #2 by igorbeslic (2012-02-07 21:02:04+00:00)
Title: Lps 24764 - upgrade notifications

Hi Mike, I'm skipping Juan as peer-reviewer and sending directly to you just to discuss my suggestion.
You'll see I added nodes that are inserted as email subjects - that was easy.
Second part was to make those notifications as close to those legacy WCM workflow notifications.
1. I removed onExit notification in review node so I can distinguish approval from rejection.
2. I added approval notification to approved state and it is triggered "onEntry"
3. I added reject notification to update task and it is triggered "onAssign"
4. All notifications are transformed to freemarker and if possible they have added link to my workflow tasks to avoid forwarding users to control panel area in which they have no permission. Also that way notifications are suitable for all kind of workflowed asset.

You will see that I left workflow portlet ID = 135 HARD CODED. Why? Well I did change to WorkflowHandlerRegistryUtil, and then I realised that there is nowhere use of that constant. Also if we ever change that portlet id - it is easier to change template than recompile portal.

If you agree with my sugesstions and have no complains to code then this can be final solution and we can pass it to Brian.

I've tested this with all scenarios and WCM and COMMENTS.

Thank you very much!