arcemu/arcemu — pull request #112 by MesoX (2012-02-07 09:01:08+00:00)
Title: Need Before Greed loot method, roll flags in general + some fixes in loot roll system

Hey!

I've somehow found that ArcEmu supports only 3 base loot methods (master looter, ffa, group loot), so I added support for Need Before Greed too.
This means I've implemented roll flags, which were previously sent into client only for NEED and GREED. This also includes disenchant roll flag, which can be selected, when anybody in group has at least same enchanting skill as item requires.
Need Before Greed - this works almost same as group loot, with addition that players, who cant use the item, can't select Need for it, like when there is plate, mage can't select for it, but it works vice-versa also for warriors, even they can use cloth. Works also with skill requirement, class and race requirement and skills for weapons are needed too.

There are few other things fixed too with this patch:
Previously, system printed roll into chat immediately after player chosen the option, but now, it prints only which option he chosen and after all players in group choose some option (or when timer runs out), it prints actual rolls for everyone and assign, who won.

I've tried to test this as much as possible and haven' found any bugs on it, but my tests are limited only to 2 players, so if anybody would mind testing this better, it would be nice.

There is 1 issue, I wasn't able to track down. When there is any kind of loot method, and somebody loots gray or white quality item, it should print, that he looted some item for all players, and even there is SendItemPushResult, it doesn't. Maybe I was just too blind or tired, when looking on it. Hope somebody will make help me making it working.