symfony/symfony — pull request #3296 by vicb (2012-02-07 18:36:25+00:00)
Title: [WIP][API Break][Feedback please]Routing

WIP, please no CS comments, other feedback is welcome !

This PR started as an attempt to fix #3264.

Some cleaning in the first three commits.

The interesting things start at commit number 4. Instead of having a separate `TraceableUrlMatcher` the logging is implemented in the base `UrlMatcher`. Yep there is a performance penalty when this matcher is used which is not the case even in debug mode with Sf2 (A cached matcher is used). I was not able to find a **simple** solution which would not impact the performance and fix tracing at the same time.

If you need a proof that the matchers are not used, this is commit number 5 which fixes a bug in one of them. (I have to check if this should be applied to 2.0 as well).

The last commit is what I wanted to achieve: you can check the routing panel in the profiler when you intercept redirects and type a url without a trailing slash.

Todo:

* CS / phpDoc,
* Fix broken tests,
* Test broken things,
* Test new features.

@fabpot any feedback ?