quicksilver/Quicksilver — pull request #690 by pjrobertson (2012-02-06 16:54:38+00:00)
Title: Dock icon visibility prefs - fixes #686, #689

These changes alter the way in which Quicksilver looks at the dock icon, and makes this much, much simpler.

Previously, Quicksilver would try and change the UIElement BOOL in the .app's Info.plist. This would mean non-admin users could not change this setting, and were 'stuck'.

With the change we made in ß63 to have UIElement set to FALSE in the Info.plist (72e2ced6a30ce184583ae574b095c4382618926a) there is actually now no need to fiddle with the BOOL in the Info.plist, and Quicksilver can respect the settings in the user's com.blacktree.Quicksilver.plist file.

Upsides: A lot of un-needed code fiddling with the Info.plist and checking if it's writable can be removed. And non-admin users can toggle the settings

Downside: For users that have the dock icon set to show, the [showDockIcon](https://github.com/pjrobertson/Quicksilver/commit/740d482faa09c8186cd06dea0818817cb26055d3#L1R140) method is run *every time* Quicksilver launches. Previously, it'd be run once to set the Info.plist UIElement BOOL. This isn't really a downside I don't think. On the whole, it's a major simplification.