trisberg/spring-framework — pull request #1 by cbeams (2012-02-04 14:56:33+00:00)
Title: Review changes for SPR-8932

Hi Thomas,

The changes in SpringSource#26 look good. I've just updated the commit comment here to follow the conventions laid out at http://progit.org/book/ch5-2.html#commit_guidelines.

You'll notice that there are two commits here, that simply because your branch was already one commit behind SpringSource/spring-framework@3.1.x. If you merge these changes into your improved-ResourceDatabasePopulator branch, your original pull request at SpringSource#26 will automatically update, at which point I'll pull it in. Of course you're free to make further changes, tweak my commit comment, or whatever.

Also, you might want to add your vmware email address to the list of email addresses known to GitHub. Your commit comes through with proper Author attribution, but it's not properly linked to your github account, probably because GitHub only knows about your springdeveloper.com address.