javan/whenever — pull request #211 by jlawler (2012-01-30 05:01:24+00:00)
Title: I'm pretty sure you won't like this patch

First off, I like your gem, I like what it does, I like the end-user syntax, and I like the command line options. Seriously, I hate everything, so I was surprised how much I like what your gem does. The only problem is that I despise using crontab for things like this and prefer to use cron.d (so they can be more readily visible and checked into version control). I decided to make a change to allow the cron.d format (basically it's just an extra column with the username).

I have a working change, but I'm not thrilled with it. I wanted to have you take a look and basically say how you would prefer this feature be implemented. My major issue is that the only way to do it less "ugly" is to make more far-reaching changes to the job and/or job_list classes.

Oh, I couldn't get your unit tests to run (both before and after I made changes). For whatever reason, it errors out on the active_support require. I'll probably take a look at it tomorrow and figure out whats happenening, but I thought you might know the source of that error off hand.

gems/rake-0.9.2/lib/rake/rake_test_loader.rb" "test/{functional,unit}/**/*_test.rb"
/home/jlawler/git/whenever/lib/whenever.rb:2:in `require': no such file to load -- active_support/all (LoadError)
from /home/jlawler/git/whenever/lib/whenever.rb:2
from /home/jlawler/git/whenever/test/test_helper.rb:3:in `require'

jlawler