bcardarella/client_side_validations — pull request #265 by bdmac (2012-01-27 22:01:31+00:00)
Title: Checkbox acceptance validation causes checkbox to uncheck immediately

I did not see an appropriate branch to make this pull request against since I forked off of master and this only seems to be a problem in master.

I ran into a problem with a checkbox validator where the checking the checkbox would immediately cause the checkbox to uncheck itself. I was able to trace back the problem to not returning true from the checkbox click handler. I'm not sure why this is a problem now since it didn't look like true was forcibly returned previously either but this change fixed the problem for me.

No tests broke as a result. I did not include a test because I didn't see any browser tests and it seems like this may be a place where the existing JS testing is not enough?