xbmc/xbmc — pull request #666 by Montellese (2012-01-27 09:37:06+00:00)
Title: Settings: replace "Network" through "Services" in settings

This commit replaces the current "Network" group in the settings with a "Services" group. For that it moves the "Internet Access" category, which was part of the "Network" group into the "System" group and splits the different service settings which are currently in the "Services" category of the "Network" group into different categories themselves (like "UPnP", "AirPlay", "Webserver" etc). This should make it a lot easier to find those specific settings. Currently the "Services" category is so badly overloaded that you have to scroll down multiple times in Confluence to finally get to the AirPlay-related settings etc.

While I reshuffled those settings I noticed that it was necessary to rename all the settings to something like "< category >.< setting >" which would have broken backwards compatibility with the current settings/guisettings.xml. So what I did is I took advantage of the fact that when calling AddFoo (AddString, AddInt etc) for every setting in CGUISettings::Initialize() we also provide the category the setting belongs to. So I added a vector of settings to every category which allows faster access/finding of all settings belonging to a certain category.

This commit also fixes Confluence but all other skins would need adjustments because the windowname changed from "NetworkSettings" to "ServiceSettings". What I didn't fix in confluence was the image displayed when the new "Services" button is focused. We can either remove the old network-related image and introduce a new one for services or we can just use the network image for services (as all the services are network-related).