meineerde/redmine_checkout — pull request #3 by marut (2012-01-26 21:45:12+00:00)
Title: Bug regarding '@' symbol in login name and display_login? setting

If a redmine username contains an '@' symbol (e.g. email address as username) and "Display Login" is selected for a given protocol (or git specifically), that user will be unable to view the "repository" page, and the server will return a 500 error. This commit works around the problem by declining to display login in checkout urls if the login name contains an '@' symbol. e.g. for 'joe@dot.com', rather than trying to display https://joe@dot.com@gitserver.com/git/project.git" and crashing, just display https://gitserver.com/git/project.git". I am not familiar at all with URI or the redmine_checkout code in general, and don't know if there's a better solution to be had using some kind of URI.encode(login, '@') scheme elsewhere.