isenseDev/iSENSE — pull request #26 by cadorett (2012-01-26 05:32:05+00:00)
Title: Validation/ Upload.php and Create.php Overhaul to return to a functional state

Restructured validate.js to allow for unique form id's, and change the code to validate all fields who are assigned the css class "required".

This allows for current and future forms to operate using the same validation.js.

Also changed an unconditional call to the readyUploadForm function to be a conditional call which will execute if the form name is "upload_form".

Line 723 to 725 of upload.php merits some questioning.

The following is the unmodified version of said lines

else {
// This value is no a time, so just plug in to the row record
echo $x[] = $val;
}

This line was echoing all of the input data to the top of the html file. This is obviously unintended behavior, so I have commented it out.

However, now the question is whether or not the "$x[] = $val;" should actually be still executing.

I'm assigning this to Hassan, just because he may know the answer to this. If not, I'll investigate it further.

I'm also assigning it to him so that he knows the original problem is fixed.