puppetlabs/puppet — pull request #402 by joshcooper (2012-01-24 22:36:49+00:00)
Title: (#12114) Qualify usages of ::File to avoid conflict with File face

Previously, if the `file` face had been loaded, then subsequent calls
to `Puppet::Application.find` would attempt to call
`Puppet::Application::File.join`, and fail since it should be calling
`::File.join`.

In addition, if `spec/unit/application_spec.rb` is tested first, then
several other order-dependent failures occurred, for the same reason
as above.

This commit uses the '::' scope resolution operator to refer to ruby's
File class and adds a spec test.

In general, if you add an application to `lib/puppet/application/`,
then you should fully qualify uses of `::File`, otherwise, if the file
face is loaded first, your application may fail.