H-uru/Plasma — pull request #120 by cwalther (2012-01-22 15:25:19+00:00)
Title: Fix use of the return key as a control key

Revision f251606 breaks using the return/enter key as a control key (e.g. for “start chat” or “jump”). The attached commit fixes that, while retaining the ability to enter line breaks in KI notes and other multi-line text edit fields that f251606 was supposed to fix.

I have not noticed any adverse effects when typing in various single-line and multi-line text input fields, however I am not sure if this is the proper fix, as I am unfamiliar with this relatively complex area of the code. Handling character input like this in the CHAR_MSG code path seems to make more sense than in the KEYDOWN code path as f251606 did it though.

I would appreciate a review by someone who has spent more time with keyboard input handling in Plasma.